[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb1a33bec7c: [OpenCL] Adjust diagnostic for subgroup support. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118999/new/ https://re

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118999/new/ https://reviews.llvm.org/D118999 _

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov updated this revision to Diff 407856. azabaznov added a comment. Use existing diagnostics; add the comment that device can support extension but not the feature. Will follow up if we need explicit mention in the language spec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia added a comment. In D118999#3296899 , @azabaznov wrote: > It seems hard to find a direct mention in the spec, but in the API spec: > > //CL_DEVICE_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS: Is CL_TRUE if this device > supports independent forward

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov added a comment. It seems hard to find a direct mention in the spec, but in the API spec: //CL_DEVICE_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS: Is CL_TRUE if this device supports independent forward progress of sub-groups, CL_FALSE otherwise. This query must return CL_TRUE for devices t

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia added a comment. Btw can you point us to the spec reference please, I can't seem to find anything related to this: https://www.khronos.org/registry/OpenCL/specs/3.0-unified/html/OpenCL_C.html#subgroup-functions. It would be nice to add the reference in the code comment too. ===

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: Naghasan, ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OpenCL C 3.0 __opencl_c_subgroups feature is slight