sammccall added inline comments.
Comment at: clang/unittests/Tooling/Syntax/Pseudo/GrammarTest.cpp:25
MATCHER_P(TargetID, SID, "") { return arg.Target == SID; }
template testing::Matcher Sequence(T... IDs) {
hokein wrote:
> sammccall wrote:
> > whoops, I mis
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfe932a88e970: [pseudo] Add first and follow set computation
in Grammar. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
hokein added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:146
+// derived from X. (Known as FIRST sets in grammar-based parsers).
+std::vector> firstSets(const Grammar &);
+// For each nonterminal X, computes the set of terminals that could imm
hokein updated this revision to Diff 407062.
hokein marked 4 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118990/new/
https://reviews.llvm.org/D118990
Files:
clang/include/clang
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:146
+// derived from X. (Known as FIRST sets in grammar-based parsers).
+std::vector> firstSets(cons
hokein updated this revision to Diff 405939.
hokein added a comment.
update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118990/new/
https://reviews.llvm.org/D118990
Files:
clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h
clang/lib/Tooling
hokein created this revision.
hokein added a reviewer: sammccall.
hokein requested review of this revision.
Herald added a project: clang.
These will be used when building parsing table for LR parsers.
Separate from https://reviews.llvm.org/D118196.
Repository:
rG LLVM Github Monorepo
https:
