[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c3309d4545: [flang][driver] Add support for `-emit-mlir` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://revie

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406828. awarzynski added a comment. - Add a test to verify that an `.mlir` file is created - Set the target triple to `native` (as opposed to relying on it being set elsewhere, e.g. https://github.com/llvm/llvm-project/blob/81cde474e2c5a6280cb693b777ddcf4

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:419 + + // ... otherwise, print to a file. + auto os{ci.CreateDefaultOutputFile( kiranchandramohan wrote: > awarzynski wrote: > > kiranchandramohan wrote: > > > Nit: Should we

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LGTM. Comment at: flang/lib/Frontend/FrontendActions.cpp:419 + + // ... otherwise, print to a file. + auto os{ci.CreateDefaultOutputFile( awarzynski wrote: > kiranchandramohan wrote:

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406398. awarzynski added a comment. Remove `auto`, update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.llvm.org/D118985 Files: clang/include/clang/Driver/Options.td

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:69 + + // Create a LoweringBridge + auto &defKinds = ci.invocation().semanticsContext().defaultKinds(); kiranchandramohan wrote: > Nit: Can we remove the three autos below? Sur

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

kiranchandramohan added a comment. Few Nits/questions. Comment at: flang/lib/Frontend/FrontendActions.cpp:69 + + // Create a LoweringBridge + auto &defKinds = ci.invocation().semanticsContext().defaultKinds(); Nit: Can we remove the three autos below? =

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406377. awarzynski added a comment. Removed trailing "_" from member variable names, added a comment, updated CMake dependencies (needed after https://reviews.llvm.org/D118966) @schweitz, thank you for reviewing! If there are no new comments, I'll merge

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:150 +//===--===// +class CodeGenAction : public FrontendAction { + schweitz wrote: > This appears in a

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

schweitz accepted this revision. schweitz added a comment. This revision is now accepted and ready to land. LGTM Comment at: flang/include/flang/Frontend/FrontendActions.h:150 +//===--===// +class CodeGenAction

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406005. awarzynski added a comment. Add missing CMake dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.llvm.org/D118985 Files: clang/include/clang/Driver/Options.td f

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added a comment. `fir-dev` PR: https://github.com/flang-compiler/f18-llvm-project/pull/1008. I've also incorporated a few small changes from the subsequent PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.l

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, clementval, schweitz. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, dang, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aar