[PATCH] D118980: Don't dllexport reference temporaries

2022-02-04 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG853e0aa424e4: Don't dllexport reference temporaries (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D118980: Don't dllexport reference temporaries

2022-02-04 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, seems reasonable! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118980/new/ https://reviews.llvm.org/D118980

[PATCH] D118980: Don't dllexport reference temporaries

2022-02-04 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. hans added reviewers: thakis, mstorsjo, rnk. hans requested review of this revision. Herald added a project: clang. Even if the reference itself is dllexport, the temporary should not be -- in fact, we're already giving it internal linkage, so dllexporting it is not ju