This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8cc4ca95b02b: [OpenMP] Add Cuda path to linker wrapper tool
(authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118944/new/
https://reviews.llvm.org/D118944
_
jhuber6 updated this revision to Diff 405799.
jhuber6 added a comment.
Use long version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118944/new/
https://reviews.llvm.org/D118944
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/tools/clang-
tianshilei1992 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8163
+CmdArgs.push_back(Args.MakeArgString(
+"-cuda-path=" + CudaInstallation.getInstallPath()));
+ break;
Would be better to keep aligned with `clang
jhuber6 updated this revision to Diff 405785.
jhuber6 added a comment.
Decided to add break.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118944/new/
https://reviews.llvm.org/D118944
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/tools/cl
jhuber6 updated this revision to Diff 405783.
jhuber6 added a comment.
Address style.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118944/new/
https://reviews.llvm.org/D118944
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/tools/clang-lin
jhuber6 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8161-8162
+ if (CudaInstallation.isValid())
+CmdArgs.push_back(Args.MakeArgString(
+"-cuda-path=" + CudaInstallation.getInstallPath()));
+}
Meinersbur wr
Meinersbur added a comment.
Thanks for the fix
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8151-8152
const char *LinkingOutput) const {
+ const auto &D = getToolChain().getDriver();
+ const auto TheTriple = getToolChain().getTriple();
+
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, tianshilei1992, Meinersbur.
Herald added subscribers: guansong, yaxunl.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
The linker wrapper tool uses the 'nv
