[PATCH] D118934: [OpenMP] Completely remove old device runtime

2022-02-03 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Don't backport. Deprecate the flag and that's fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118934/new/ https://reviews.llvm.org/D118934 ___ cfe-commits mailing list cfe-

[PATCH] D118934: [OpenMP] Completely remove old device runtime

2022-02-03 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. If this patch can be back ported to 14, then it's totally fine to remove the argument. Otherwise keeping it sounds more reasonable. If we keep it, we'd better to emit a warning and then we could remove it in 15 or other version w/o any concern that we don't tell

[PATCH] D118934: [OpenMP] Completely remove old device runtime

2022-02-03 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,

[PATCH] D118934: [OpenMP] Completely remove old device runtime

2022-02-03 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,

[PATCH] D118934: [OpenMP] Completely remove old device runtime

2022-02-03 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I've read this closely and can't think of anywhere else that needs to be patched. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D118934: [OpenMP] Completely remove old device runtime

2022-02-03 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue, -