jdoerfert added a comment.
Don't backport. Deprecate the flag and that's fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118934/new/
https://reviews.llvm.org/D118934
___
cfe-commits mailing list
cfe-
tianshilei1992 added a comment.
If this patch can be back ported to 14, then it's totally fine to remove the
argument. Otherwise keeping it sounds more reasonable. If we keep it, we'd
better to emit a warning and then we could remove it in 15 or other version w/o
any concern that we don't tell
JonChesterfield added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2470
Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
-defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime",
- LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,
jhuber6 added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2470
Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
-defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime",
- LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,
JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.
I've read this closely and can't think of anywhere else that needs to be
patched. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
tianshilei1992 added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2470
Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
-defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime",
- LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,
-