[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

2022-02-20 Thread Iain Sandoe via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8a3f9a584ad4: [C++20][Modules][1/8] Track valid import state. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

2022-02-17 Thread Iain Sandoe via Phabricator via cfe-commits
iains updated this revision to Diff 409546. iains added a comment. amended an assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/inc

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

2022-02-17 Thread Iain Sandoe via Phabricator via cfe-commits
iains marked 4 inline comments as done. iains added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:144 GlobalModuleFragment = ModuleScopes.back().Module; // In C++20, the module-declaration must be the first declaration if there ChuanqiXu wr

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

2022-02-17 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Comment at: clang/lib/Sema/SemaModule.cpp:144 GlobalModuleFragment = ModuleScopes.back().Module; // In C++20, the module-declaration must be the first declaration if there iains wrote:

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

2022-02-17 Thread Iain Sandoe via Phabricator via cfe-commits
iains marked 5 inline comments as done. iains added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:82 if (getLangOpts().Modules || getLangOpts().DebuggerSupport) { - SingleDecl = ParseModuleImport(AtLoc); + Sema::ModuleImportState IS = Sema::ModuleImpor

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

2022-02-17 Thread Iain Sandoe via Phabricator via cfe-commits
iains updated this revision to Diff 409521. iains added a comment. address review comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 Files: clang/include/clang/Basic/DiagnosticParseKinds.t

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

2022-02-16 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2955-2960 +FirstDecl, +GlobalFragment, +ImportAllowed, +ImportFinished, +PrivateFragment, +NotACXX20Module I guess it is worth to add comment for these fields. Al

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

2022-02-16 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. thanks for indexing the subject lines! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 _

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

2022-02-16 Thread Iain Sandoe via Phabricator via cfe-commits
iains marked 5 inline comments as done. iains added a comment. also reformatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 ___ cfe-commits mailing list cf