This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc6f8704053ba: [clang][deps] Disable global module index
(authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.
lgtm. I agree that testing this isn't really necessary given the difficulty of
even constructing one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
jansvoboda11 added a comment.
I'd like to add a test case, but actually creating a minimal one is proving to
be difficult. This is most likely caused by the interaction between the global
module index and explicit+implicit modules. Since we want to move off of the
implicit build in dependency s
jansvoboda11 created this revision.
Herald added a subscriber: arphaman.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
While scanning dependencies of a TU that depends on a PCH, the scanner
basically performs mixed implicit/
