[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

yaxunl added a comment. It has been cherry-picked to 14.x by 02d5b112 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876 ___

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG171da443d598: [HIPSPV] Fix literals are mapped to Generic address space (authored by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

tstellar added a comment. @yaxunl This looks good to me, you can go ahead and cherry-pick it directly to release/14.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

yaxunl added a subscriber: tstellar. yaxunl added a comment. In D118876#3295958 , @linjamaki wrote: > Thanks for the review, @yaxunl. Could you push this to the LLVM? And to the > LLVM 14 release branch too, if possible? Sure. @tstellar What is the curr

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

linjamaki added a comment. Thanks for the review, @yaxunl. Could you push this to the LLVM? And to the LLVM 14 release branch too, if possible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876 ___

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876 __

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

linjamaki created this revision. Herald added a subscriber: yaxunl. linjamaki edited the summary of this revision. Herald added a subscriber: Anastasia. linjamaki published this revision for review. linjamaki added reviewers: Anastasia, yaxunl. Herald added a project: clang. Herald added a subscrib