[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

krasimir added a comment. Thank you! Turns out the original source wasn't using an ascii space for the comment indentation but a unicode [c2 a0] no-break space: 2f 2f c2 a0 43 6f 6d 6d 65 6e 74 0a 69 6e 74 20 |//..Comment.int | IMO we shouldn't aim to handle non-ascii spaces for indentation

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

ksyx added a comment. In D118869#3359439 , @krasimir wrote: > It appears that this caused a regression by adding an additional space of > indentation to line comments in some cases: > > % cat test.cc # (before) > // Comment > int i; > % clang-fo

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

krasimir added a comment. Herald added a project: All. It appears that this caused a regression by adding an additional space of indentation to line comments in some cases: % cat test.cc # (before) // Comment int i; % clang-format -style=google test.cc //  Comment int i; @ksyx coul

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88e4e6be16ea: [clang-format] Use wider comment prefix space rule (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

ksyx added subscribers: byronhe, CoelacanthusHex. ksyx added a comment. Related discussion: https://reviews.llvm.org/D92257#3252060 Proposed by @byronhe cc @CoelacanthusHex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118869/new/ https://reviews

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

ksyx created this revision. ksyx added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius. ksyx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit changes the condition of requiring comment to start with alphabet characters to