This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7e80976fdf3f: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes
(authored by ychen).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https
ychen added a comment.
@probinson Thanks. No worries. I should've pinged earlier.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118850/new/
https://reviews.llvm.org/D118850
___
cfe-commits mailing list
c
probinson accepted this revision.
probinson added a comment.
LGTM, sorry I missed this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118850/new/
https://reviews.llvm.org/D118850
___
cfe-commits mailing
ychen added a comment.
Herald added a project: All.
@aaron.ballman Thanks for taking a look.
@probinson Gentle ping..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118850/new/
https://reviews.llvm.org/D118850
__
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM as far as the changes go (I can't speak to how appropriate the changes are
for the PS4 target).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
ychen created this revision.
ychen added a reviewer: probinson.
ychen requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
So it matches `__STDCPP_DEFAULT_NEW_ALIGNMENT__`.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D11885
