[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe marked an inline comment as done. Febbe added a comment. Thank you for the review. I am done and you can commit the patch :) . I don't have the rights to commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118847/new/ https://reviews.llvm.org/D118847 __

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe updated this revision to Diff 407200. Febbe marked 4 inline comments as done. Febbe added a comment. Last batch of suggested changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118847/new/ https://reviews.llvm.org/D118847 Files: clang-tools-extra/clang-tidy/modernize/UseTrail

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev added a comment. In D118847#3307497 , @Febbe wrote: > Can I still add a diff, or does this cause a revoke (apply the rest of the > feedback)? > Also, is the commit added automatically to the repo, or do I / another one > have to rebase it. > >

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe added a comment. Can I still add a diff, or does this cause a revoke (apply the rest of the feedback)? Also, is the commit added automatically to the repo, or do I / another one have to rebase it. Sorry for those questions, this is my first contribution to llvm. CHANGES SINCE LAST ACTI

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type-cxx20.cpp:71 + template + requires(T{0}) // + friend conste

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type-cxx20.cpp:71 + template + requires(T{0}) // + friend constexpr auto kbobyrev wrote: > nit: `//` looks unrelated I used the `//` to brea

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:407 - if (F->getLocation().isInvalid()) + // operator<=> generates also the AST of e.g. operator==, which is implicit + if (F->getLocation().isInvalid() || F->i

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Febbe updated this revision to Diff 407115. Febbe retitled this revision from "Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes llvm#53355" to "Added early exit for defaulted FunctionDecls.". Febbe edited the summary of this revision.

[PATCH] D118847: Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes llvm#53355

kbobyrev added a comment. Mostly LG with few nits. I think it might be able to make it into the 14 release if we cherry-pick into the release branch. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:407 - if (F->getLocation().isInvalid()) +

[PATCH] D118847: Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes llvm#53355

Febbe added a comment. Push, would be nice to see this in the llvm-14 release. I can also do a review for someone else as a favor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118847/new/ https://reviews.llvm.org/D118847

[PATCH] D118847: Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes llvm#53355

Febbe created this revision. Herald added a subscriber: carlosgalvezp. Febbe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118847 Files: clang-tools-extra/cla