[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

This revision was automatically updated to reflect the committed changes. Closed by commit rG71d7c8d870db: [clangd] Crash in __memcmp_avx2_movbe (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.ll

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko added a comment. In D118755#3301776 , @sammccall wrote: > Do you have access to commit this or should I land it for you? I would appreciate your assistance in the land. You can use the following email address: `ivan.murashko at gmail.com`

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

sammccall added a comment. Do you have access to commit this or should I land it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 ___ cfe-commits mailin

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 406421. ivanmurashko added a comment. comment update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files: clang/include/clang/Tooling/Inclusions/HeaderInclud

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 406420. ivanmurashko edited the summary of this revision. ivanmurashko added a comment. Comment about std::list was added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h:101 // and "x" will be treated as the same header when deleting #includes. - llvm::StringMap> ExistingIncludes; + llvm::StringMap> ExistingIncludes; May be

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 __

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h:100 // and "x" will be treated as the same header when deleting #includes. llvm::StringMap> ExistingIncludes; sammccall wrote: > An alternative would b

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 406411. ivanmurashko added a comment. There are some changes: - unit test for HeaderIncludes was added - lit test for clangd was removed - Solution uses std::list instead of copying by value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

sammccall added a comment. Thanks! This fix makes sense to me. Comment at: clang-tools-extra/clangd/test/repeated_includes.test:1 +# RUN: rm -rf %/t +# RUN: mkdir -p %t && touch %t/t.h && touch %t/t2.h && touch %t/t3.h This should be tested more directly rather

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 405886. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files: clang-tools-extra/clangd/test/repeated_includes.test clan

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 405814. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files: clang-tools-extra/clangd/test/repeated_includes.test clan

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

DmitryPolukhin added a comment. @ivanmurashko Overall looks good to me but please re-upload patch on top of some stable revision where failed test passes (it seems unrelated to your changes). `struct Include` is a light weight structure so having a copy seems to be the simplest solution. Rep

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:328 ExistingIncludes.try_emplace(trimInclude(IncludeToAdd.Name)).first; Iter->second.push_back(std::move(IncludeToAdd)); auto &CurInclude = Iter->second.back(); --

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko created this revision. ivanmurashko added reviewers: alexfh, DmitryPolukhin, sammccall, bruno. ivanmurashko added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. ivanmurashko requested review of this revision. Herald added subscribers: cfe-c