[PATCH] D118666: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils

2022-01-31 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85dfe19b36ba: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils (authored by MaskRay). Changed prior to commit: https://reviews.llvm.o

[PATCH] D118666: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils

2022-01-31 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/include/llvm/Bitcode/BitcodeWriter.h:168 - /// Embeds the memory buffer \p Buf into the module \p M as a global using the - /// section name \p SectionName. Note that the convention is to use imperative sentenc

[PATCH] D118666: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils

2022-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118666/new/ https://reviews.llvm.org/D118666

[PATCH] D118666: [ModuleUtils] Move EmbedBufferInModule to LLVMTransformsUtils

2022-01-31 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: jhuber6, JonChesterfield. Herald added subscribers: ormris, hiraditya, mgorny. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. D116542