[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i8 [[TMP

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr; + tianshilei1992 wrote: > ABataev wrot

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr;

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i8 [[TMP

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr; + tianshilei1992 wrote: > tianshilei19

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. In D118632#3336145 , @ABataev wrote: > In D118632#3336133 , > @tianshilei1992 wrote: > >> In D118632#3336094 , @ABataev >> wrote: >> >>>

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

ABataev added a comment. In D118632#3336133 , @tianshilei1992 wrote: > In D118632#3336094 , @ABataev wrote: > >> LG with a nit > > Actually I got two question in the inline comments. Can you please take a > look

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. In D118632#3336094 , @ABataev wrote: > LG with a nit Actually I got two question in the inline comments. Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/include/clang/AST/StmtOpenMP.h:2970 + } + /// Get + Expr *getCondExpr() { Fix comment Repository: rG LLVM Github Mon

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:6 + +// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -target-cpu core2 -fopenmp-simd -fopenmp-version=51 -x c -emit-llvm %s -o

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:6 + +// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -target-cpu core2 -fopenmp-simd -fopenmp-version=51 -x c -emit-llvm %s -o - | FileCheck --check-prefix SIMD-ONLY0 %s +// %clang_

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr; + Using `D->IgnoreImpCasts()` c

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i