[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

svenvh added a comment. In D118605#3313990 , @Anastasia wrote: > In D118605#3313859 , @azabaznov > wrote: > >>> There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so >>> we need this check t

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

This revision was automatically updated to reflect the committed changes. Closed by commit rGbee4bd70f769: [OpenCL] Add support of language builtins for OpenCL C 3.0 (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 _

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added a comment. In D118605#3313859 , @azabaznov wrote: >> There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so >> we need this check to preserve the existing behavior indeed. > > Thanks. The other test is `SemaOpenCL/clan

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added a comment. > There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so we > need this check to preserve the existing behavior indeed. Thanks. The other test is `SemaOpenCL/clang-builtin-version.cl`. > But it might be worth asking someone outside of the OpenCL co

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 407823. azabaznov added a comment. Rename language mode for device side enqueue builtins; add the comment that device side enqueue builtins are not supported until OpenCL 2.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:79 + bool OclBlocksUnsupported = + (LangOpts.getOpenCLCompatibleVersion() < 200 || !LangOpts.Blocks) && + (BuiltinInfo.Langs & OCL_BLOCKS); svenvh wrote: > azabaznov wrote: > > T

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

svenvh added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). --

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added a comment. @Anastasia @svenvh ping. Just a kind reminder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 ___ cfe-commits mailing list cfe-commi

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov marked 4 inline comments as done. azabaznov added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:79 + bool OclBlocksUnsupported = + (LangOpts.getOpenCLCompatibleVersion() < 200 || !LangOpts.Blocks) && + (BuiltinInfo.Langs & OCL_BLOCKS); ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 406434. azabaznov added a comment. Check only against specific language option, remove unused LanguageIDs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: c

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.h:39 + COR_LANG = 0x80, // builtin requires use of 'fcoroutine-ts' option. + OCLC2P_LANG = 0x100, // builtin for OpenCL C 2.0+ versions. + OCLC1X_LANG = 0x200, // builtin for OpenCL C 1.x only.

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 405921. azabaznov added a comment. Reimplement with checking language options only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: clang/include/clang/Bas

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 404511. azabaznov added a comment. Remove no longer required comment in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 Files: clang/include/clang/Basic

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: Naghasan, ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenCL