balazske marked 2 inline comments as done.
balazske added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:151
CallGraphNode *HandlerNode = CG.getNode(HandlerDecl);
- // Signal handler can be external but not unsafe, no call graph in t
balazske updated this revision to Diff 404040.
balazske added a comment.
Even more simplification, added documentation.
Text of bug reports is more detailed, no NFC now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118370/new/
https://reviews.llvm
njames93 added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:167
+ const Expr *CallOrRef) {
+ const bool FunctionIsCalled = isa(CallOrRef);
+
This can probably just be inlined into
balazske added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:146
+ if (!HandlerDecl->hasBody()) {
+checkFunction(HandlerDecl, HandlerExpr);
return;
LegalizeAdulthood wrote:
> Why do we ignore the return value
LegalizeAdulthood added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:146
+ if (!HandlerDecl->hasBody()) {
+checkFunction(HandlerDecl, HandlerExpr);
return;
Why do we ignore the return value of `checkFunction`
balazske created this revision.
Herald added subscribers: carlosgalvezp, steakhal, martong, gamesh411,
Szelethus, dkrupp, xazax.hun.
balazske requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Another change of the code design.
Co
