[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e115b7d8811: [RISCV] Update computeTargetABI from llc as well as clang (authored by khchen). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. In D118333#3329422 , @asb wrote: > Thanks, I've put this on the agenda for the RISC-V LLVM sync call today. I > think this is more attractive than the previ

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/double-mem.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d -verify-machineinstrs < %s \ +; RUN: llc -mtriple=riscv32 -mattr=+d -target-abi=

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

asb added a comment. Thanks, I've put this on the agenda for the RISC-V LLVM sync call today. I think this is more attractive than the previous proposal due to unifying logic between llc and Clang. I could see a counter-argument about llc being a low-level tool that should be controlled very ex

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

khchen updated this revision to Diff 406842. khchen added a comment. rebase on D119250 to make changes clear. Thanks for kito's suggestion! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118333/new/ https://review

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

khchen added a comment. clang will calculate the default target-abi if -mabi is empty and encode the it in LLVM IR module flag. then if llc has no target-abi option (`Options.MCOptions.ABIName` is empty), in getSubtargetImpl it uses different way to compute the default target-abi, then the defa