[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 added a comment. In D118095#3408037 , @aykevl wrote: > @MaskRay it was my suggestion to move this from the toolchain specific file > to the generic file, because it makes the implementation much simpler. See my > comment D117423#3251110

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

aykevl added a comment. Herald added a subscriber: StephenFan. @MaskRay it was my suggestion to move this from the toolchain specific file to the generic file, because it makes the implementation much simpler. See my comment D117423#3251110 for details.

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 412300. Herald added a project: All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/Too

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 404344. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 added a comment. The other implementation (https://reviews.llvm.org/D117423) is abundoned, since we should not put AVR specified checks in the common code in Clang.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 ___

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 404340. benshi001 retitled this revision from "[AVR][clang] Reject non assembly source files for the avr1 family" to "[clang][AVR] Reject non assembly source files for the avr1 family". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ htt