Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

2015-08-14 Thread Hans Wennborg via cfe-commits
I'm OK with it if Richard gives owner's approval. Cheers, Hans On Thu, Aug 13, 2015 at 8:27 PM, Martell Malone wrote: > Hi Hans, > > Is this bugfix something that can be merged into 3.7 ? > > Kind Regards > Martell > > On Thu, Aug 13, 2015 at 4:42 PM, Martell Malone > wrote: >> >> This revision

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

2015-08-13 Thread Martell Malone via cfe-commits
Hi Hans, Is this bugfix something that can be merged into 3.7 ? Kind Regards Martell On Thu, Aug 13, 2015 at 4:42 PM, Martell Malone wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL244902: Driver: Fix include directories when not using >

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

2015-08-13 Thread Martell Malone via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL244902: Driver: Fix include directories when not using libgcc under mingw (authored by martell). Changed prior to commit: http://reviews.llvm.org/D11808?vs=32007&id=32062#toc Repository: rL LLVM htt

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

2015-08-12 Thread Yaron Keren via cfe-commits
yaron.keren added a comment. Yes, go ahead. http://reviews.llvm.org/D11808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

2015-08-12 Thread Martell Malone via cfe-commits
martell updated this revision to Diff 32007. martell added a comment. Updated to address yaron's comments. Okay for me to merge now ? http://reviews.llvm.org/D11808 Files: lib/Driver/MinGWToolChain.cpp test/Driver/Inputs/mingw_clang_tree/mingw32/i686-w64-mingw32/include/.keep test/Driver

[PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

2015-08-06 Thread Martell Malone via cfe-commits
martell created this revision. martell added a reviewer: yaron.keren. martell added a subscriber: cfe-commits. When gcc is not installed we fail to set the correct include and lib directory. In some cases base is set and we might want to use clang without gcc being installed http://reviews.llvm.