[PATCH] D118070: Add /winsysroot support to lld

2022-02-01 Thread Peter Kasting via Phabricator via cfe-commits
pkasting marked 9 inline comments as done. pkasting added a comment. In D118070#3278123 , @thakis wrote: > Things that can still improve: > > 1. This now does way more than just /winsysroot:. It also makes it so that > lld-link works in a non-msvc shell

[PATCH] D118070: Add /winsysroot support to lld

2022-01-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This looks super nice. Things that can still improve: 1. This now does way more than just /winsysroot:. It also makes it so that lld-link works in a non-msvc shell by looking up libpaths in either registry or via setup api. 2. Some of the new lld-link code still looks (

[PATCH] D118070: Add /winsysroot support to lld

2022-01-27 Thread Peter Kasting via Phabricator via cfe-commits
pkasting updated this revision to Diff 403679. pkasting added a comment. Herald added subscribers: hiraditya, mgorny. Refactored to share code with clang-cl. Still no tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews

[PATCH] D118070: Add /winsysroot support to lld

2022-01-26 Thread Peter Kasting via Phabricator via cfe-commits
pkasting updated this revision to Diff 403316. pkasting edited the summary of this revision. pkasting added a comment. Functional, but not yet refactored to share code with clang-cl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https:/

[PATCH] D118070: Add /winsysroot support to lld

2022-01-26 Thread Peter Kasting via Phabricator via cfe-commits
pkasting updated this revision to Diff 403265. pkasting added a comment. Herald added subscribers: cfe-commits, dexonsmith, mstorsjo. Herald added a project: clang. Adds autodetection and full support for other clang-cl switches, but doesn't work: config->machine is not set this early, so it's al