[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6afa9e6b0d9: [Driver] Use libatomic for 32-bit SPARC atomics support (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/test/Driver/solaris-ld.c:46 // CHECK-LD-SPARC64-SAME: "-L[[SYSROOT]]/usr/lib/sparcv9" +// CHECK-LD-SPARC64-NOT: "-zignore" +// CHECK-LD-SPARC64-NOT: "-latomic" ro wrote: > MaskRay wrote: > > Such NOT patterns are usu

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 407455. ro marked an inline comment as done. ro added a comment. Simplify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews.llvm.org/D118021 Files: clang/lib/Driver/ToolChains/Common

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro marked an inline comment as done. ro added inline comments. Comment at: clang/test/Driver/solaris-ld.c:20 // CHECK-LD-SPARC32-SAME: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD-SPARC32-SAME: "-zignore" +// CHECK-LD-SPARC32-SAME: "-latomic" MaskRay wrote: > If they ar

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/solaris-ld.c:20 // CHECK-LD-SPARC32-SAME: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD-SPARC32-SAME: "-zignore" +// CHECK-LD-SPARC32-SAME: "-lato

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 407120. ro added a comment. Add tests in `solaris-ld.c`. Spot-checked by running the single test with `llvm-lit` on `sparcv9-sun-solaris2.11`, `amd64-solaris2.11`, and `x86_64-pc-linux-gnu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. In D118021#3307079 , @MaskRay wrote: > This needs some tests, otherwise there is a risk that others may break your > changes when refactoring driver code. I thought it would be enough that any breakage there would cause a large numbe

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

MaskRay added a comment. This needs some tests, otherwise there is a risk that others may break your changes when refactoring driver code. The style I favor most is `test/Driver/linux-cross.cpp`. freebsd.c is not too bad. linux-ld.c is somewhat messy but can give you some idea what to test. I'l

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. Ping^2. It would be great if this could be reviewed/commited soon: it fixes hundreds of testsuite failures, so I'd like to get it into LLVM 14. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. Ping? It's been a week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews.llvm.org/D118021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > glaubitz wrote: > > ro wrote: > > > ro wr

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > ro wrote: > > ro wrote: > > > glaubitz wr

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. ro wrote: > ro wrote: > > glaubitz wrote: > > > ro wrote: >

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 403607. ro marked an inline comment as done. ro added a comment. Omit `sanitizer_atomic_clang.h` part, belongs to D118021 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 403604. ro added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. - Clarify comment. - Use `__ATOMIC_SEQ_CST`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://r

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:138-139 +if (getToolChain().getTriple().getArch() == llvm::Triple::sparc) { + CmdArgs.push_back(getAsNeededOption(getToolChain(), true)); + CmdArgs.push_back("-latomic"); + CmdA

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > ro wrote: > > glaubitz wrote: > > > joerg wrote

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. ro wrote: > glaubitz wrote: > > joerg wrote: > > > This com

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > joerg wrote: > > This comment is misleading. It

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. joerg wrote: > This comment is misleading. It's not so much

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

joerg added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. This comment is misleading. It's not so much that LLVM doesn't

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:138-139 +if (getToolChain().getTriple().getArch() == llvm::Triple::sparc) { + CmdArgs.push_back(getAsNeededOption(getToolChain(), true)); + CmdArgs.push_back("-latomic"); + CmdA

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added a comment. Ah, I actually ran into this very problem! Thanks for fixing this. Will test this today on Linux and report back! Could you maybe have a look at my updated revision here? https://reviews.llvm.org/D98575 I think this particular change should be save on Solaris as well.

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro created this revision. ro added reviewers: jyknight, venkatra, efriedma, jrtc27. ro added a project: clang. Herald added a subscriber: fedor.sergeev. ro requested review of this revision. Herald added a subscriber: cfe-commits. Even after D86621 , `clang -m32` o