This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rG0cf75aac42eb: [clangd] Enable hover on character literal.
(authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:1254
+ [](HoverInfo &HI) {
+ HI.Name = "expression", HI.Type = "char";
+
hokein added a comment.
friendly ping, I think it would be nice to get it in before 14 release.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117864/new/
https://reviews.llvm.org/D117864
___
cfe-commits
hokein added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:733
llvm::isa(E) || llvm::isa(E) ||
llvm::isa(E) || llvm::isa(E);
}
there may be some value to enable StringLiteral as well (e.g. see the length of
the string), but
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
In the initial hover expression patch (https://revi
