[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG9385ece95a4a: [HeaderSearch] Track framework name in LookupFile (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D117830?vs=403340&id=

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

cishida added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1043 // If this file is found in a header map and uses the framework style of // includes, then this header is part of a framework we're building. dgoldman wrote: > cishida wrot

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1043 // If this file is found in a header map and uses the framework style of // includes, then this header is part of a framework we're building. ---

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman updated this revision to Diff 403340. dgoldman added a comment. Update comment + run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117830/new/ https://reviews.llvm.org/D117830 Files: clang/lib/Lex/HeaderSearch.cpp clang/u

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

jansvoboda11 added a comment. I don't have any suggestions here except for running the patch through `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117830/new/ https://reviews.llvm.org/D117830 __

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

cishida accepted this revision. cishida added a comment. This revision is now accepted and ready to land. I followed up about this approach with folks more familiar with SourceKit and seems fine, so LGTM. I'd wait a day to see if Jan has any concerns. Comment at: clang/lib/Lex

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman added a comment. In D117830#3267404 , @cishida wrote: > My understanding for the header map restriction is because headermaps are > generally emitted once for a framework build and only consumed to build such > framework and this struct informa

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

cishida added a comment. My understanding for the header map restriction is because headermaps are generally emitted once for a framework build and only consumed to build such framework and this struct information is only queried during this. It sounds like for the clangd support, you're not as

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman added a comment. Cyndy and Jan, hopefully ya'll are the right reviewers here? We're using this Framework information to know to compute framework style includes in https://reviews.llvm.org/D117056 for clangd, please LMK if this is a bad idea and we should do something else. Repositor

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

sammccall resigned from this revision. sammccall added subscribers: jansvoboda11, cishida. sammccall added a comment. Thanks for splitting this out from the other patch. This feels subtle and I don't think I know enough about frameworks to review. @cishida made a recent change here which @jansvo

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman created this revision. dgoldman added a reviewer: sammccall. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the Framework name was only set if the file came from a header mapped framework; now we'll always set