This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9d3437fbf341: [ADT] [NFC] Add StringRef::detectEOL (authored
by beanz).
Changed prior to commit:
https://reviews.llvm.org/D117626?vs=401074&id=401
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Sounds good to me
Comment at: llvm/unittests/ADT/StringRefTest.cpp:1114-1116
+ for (const auto &Entry : Cases) {
+EXPECT_EQ(StringRef("\n"), Entry.detectEOL());
+ }
beanz updated this revision to Diff 401074.
beanz added a comment.
Fixing the CR test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117626/new/
https://reviews.llvm.org/D117626
Files:
clang/lib/Frontend/Rewrite/InclusionRewriter.cpp
llvm/
beanz updated this revision to Diff 401071.
beanz added a comment.
Minor fix to properly handle classic mac... because it is _very_ important.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117626/new/
https://reviews.llvm.org/D117626
Files:
clan
beanz created this revision.
beanz added reviewers: rnk, jyknight, dexonsmith.
beanz requested review of this revision.
Herald added projects: clang, LLVM.
This change moves EOL detection out of the clang::InclusionRewriter into
llvm::StringRef so that it can be easily reused elsewhere. It also ad
