[PATCH] D117587: [ifs] Use a tmp file instead of "-"

2022-01-21 Thread Jake Egan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf24fe96f469b: [ifs] Use a tmp file instead of "-" (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.or

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

2022-01-19 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587 ___ cfe-com

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

2022-01-19 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan added inline comments. Comment at: clang/test/InterfaceStubs/object.c:2 // RUN: %clang_cc1 -fvisibility default -o - -emit-interface-stubs %s | FileCheck -check-prefix=CHECK-TAPI %s -// RUN: %clang -fvisibility=default -c -o - %s | llvm-nm - 2>&1 | FileCheck -check-p

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

2022-01-19 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan updated this revision to Diff 401254. Jake-Egan marked an inline comment as done. Jake-Egan added a comment. Removed the unncessary pipe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587 Files:

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

2022-01-19 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/InterfaceStubs/object.c:2 // RUN: %clang_cc1 -fvisibility default -o - -emit-interface-stubs %s | FileCheck -check-prefix=CHECK-TAPI %s -// RUN: %clang -fvisibility=default -c -o - %s | llvm-nm - 2>&1 | FileCh

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

2022-01-19 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. We should update the description to reflect the cause more accurately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587 _

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

2022-01-19 Thread Digger Lin via Phabricator via cfe-commits
DiggerLin accepted this revision. DiggerLin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587 _

[PATCH] D117587: [ifs] Use a tmp file instead of -

2022-01-18 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117587 Files: clang/test/InterfaceStubs/object.c Index: clang/test/InterfaceStu