This revision was automatically updated to reflect the committed changes.
Closed by commit rL244568: Propagate SourceLocations through to get a Loc on
float_cast_overflow (authored by filcab).
Changed prior to commit:
http://reviews.llvm.org/D11757?vs=31429&id=31765#toc
Repository:
rL LLVM
filcab updated this revision to Diff 31429.
filcab added a comment.
Rebasing off of current trunk.
compiler-rt patch posted at http://reviews.llvm.org/D11793
http://reviews.llvm.org/D11757
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprComplex.cpp
lib/CodeGen/CGExprScalar.cpp
lib/Code
filcab added a comment.
Marking Richard's comment as done.
http://reviews.llvm.org/D11757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
Looks good to me too (though please hold off on this until you and samsonov
have agreed on what to do about the ubsan ABI change).
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1288
@@ -1287,3 +1287,3 @@
OpenMPDirectiveKind Kind,
-
filcab added a comment.
In http://reviews.llvm.org/D11757#218153, @samsonov wrote:
> Note that you would need to make a corresponding change in UBSan compiler-rt
> runtime.
I finished this late last night, so I figured I'd upload the bigger patch and
start getting comments. :-)
> Also, this
samsonov added a comment.
Thank you for working on this! This change looks good to me, but I'll let
Richard say a final word.
Note that you would need to make a corresponding change in UBSan compiler-rt
runtime. Also, this is an ABI-breaking change - e.g. shared objects built with
older Clang
filcab created this revision.
filcab added reviewers: rsmith, ABataev, rjmccall.
filcab added a subscriber: cfe-commits.
float_cast_overflow is the only UBSan check without a source location attached.
This patch propagates SourceLocations where necessary to get them to the
EmitCheck() call.
http:
