[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

2022-01-18 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:190 Env.setValue(Loc, Env.takeOwnership(std::make_unique( SubExprVal->getPointeeLoc(; + break; sgatev wrote: > xazax.hun wrote:

[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

2022-01-18 Thread Stanislav Gatev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sgatev marked an inline comment as done. Closed by commit rG59e031ff9057: [clang][dataflow] Add transfer function for addrof (authored by sgatev). Repository: rG LLV

[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

2022-01-18 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:190 Env.setValue(Loc, Env.takeOwnership(std::make_unique( SubExprVal->getPointeeLoc(; + break; ---

[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

2022-01-17 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. The address-of part looks good to me. However, just realized that I'm not convinced whether the dereference operator, or references, in general, are correctly handled. ===

[PATCH] D117496: [clang][dataflow] Add transfer function for addrof

2022-01-17 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis