[PATCH] D117463: [clangd] Disable expand-auto action on constrained auto.

2022-01-23 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D117463#3247915 , @sammccall wrote: > My intuition is that constrained auto is unlikely to be used in deducible > contexts, but maybe some people will like `Iterator auto I = > foo.begin()` or so... I expect this to be fairly

[PATCH] D117463: [clangd] Disable expand-auto action on constrained auto.

2022-01-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/ExpandAutoTypeTests.cpp:88 + R"cpp(template concept C = true; +^C a^uto abc(); +)cpp"); hokein wrote: > sammccall wrote: > > This shouldn't be unavailable because it'

[PATCH] D117463: [clangd] Disable expand-auto action on constrained auto.

2022-01-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/ExpandAutoTypeTests.cpp:88 + R"cpp(template concept C = true; +^C a^uto abc(); +)cpp"); sammccall wrote: > This shouldn't be unavailable because it's constrained, it sho

[PATCH] D117463: [clangd] Disable expand-auto action on constrained auto.

2022-01-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. I'm missing some context on this patch. My intuition is that constrained auto is unlikely to be used in deducible contexts, but maybe some people will like `Iterator auto I = foo.begin()` or so... Comment at: clang-tools-extra/clangd/refactor/tweaks

[PATCH] D117463: [clangd] Disable expand-auto action on constrained auto.

2022-01-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo h