[PATCH] D117428: [docs] Clarify & update JSONCompilationDatabase docs

2022-01-17 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16949762dc6a: [docs] Clarify & update JSONCompilationDatabase docs (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D117428: [docs] Clarify & update JSONCompilationDatabase docs

2022-01-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/JSONCompilationDatabase.rst:95 + + Either **arguments** or **command** is required. **arguments** is preferred, + as shell (un)escaping is a po

[PATCH] D117428: [docs] Clarify & update JSONCompilationDatabase docs

2022-01-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang/docs/JSONCompilationDatabase.rst:95 + + Either **arguments** or **command** is required. **arguments** is preferred, + as shell (un)escaping is a possible source of errors. Hopefully I'm not too far out on a

[PATCH] D117428: [docs] Clarify & update JSONCompilationDatabase docs

2022-01-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - prefer `arguments` over `command`, and add example - clarify that there's no shell-unescaping of `arguments` F