LegalizeAdulthood accepted this revision.
LegalizeAdulthood added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.
If the only thing holding this up is my comments about following the Law of
Demeter, I don't think that should block submitting this change.
LegalizeAdulthood added inline comments.
Comment at: clang-tools-extra/clang-tidy/IncludeInserter.h:20
namespace tidy {
-namespace utils {
njames93 wrote:
> LegalizeAdulthood wrote:
> > njames93 wrote:
> > > LegalizeAdulthood wrote:
> > > > What's the guidance
njames93 marked an inline comment as done.
njames93 added inline comments.
Comment at: clang-tools-extra/clang-tidy/IncludeInserter.h:20
namespace tidy {
-namespace utils {
LegalizeAdulthood wrote:
> njames93 wrote:
> > LegalizeAdulthood wrote:
> > > What's th
LegalizeAdulthood added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:220-238
+llvm::Optional
+ClangTidyCheck::createMainFileIncludeInsertion(StringRef Include) {
+ if (!Context->hasIncludeInserter()) {
+// Only crash on debug builds
+asser
njames93 created this revision.
Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman,
kbarton, xazax.hun, mgorny, nemanjai.
Eugene.Zelenko added reviewers: aaron.ballman, LegalizeAdulthood.
Eugene.Zelenko added a project: clang-tools-extra.
njames93 updated this revision to Diff
