[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added a comment. Revert: To github.com:llvm/llvm-project.git bdf573652138..3f05192c4c40 main -> main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 _

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added a comment. Yep, I just noticed. Reverting for now and will fix LLDB before recommitting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

thakis added a comment. Very cool! Looks like it broke lldb builds though: http://45.33.8.238/linux/68321/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 __

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d9b91524ea4: [Preprocessor] Reduce the memory overhead of `#define` directives (authored by arphaman). Herald added a project: clang. Repository:

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

aaron.ballman accepted this revision. aaron.ballman added a comment. Thanks, this LGTM as well! I don't think the precommit CI pipeline failures are related from what I can tell. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

dexonsmith added a comment. LGTM once @aaron.ballman is happy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { aaron.ballman wrote: > dexonsmith wrote: > > aaron.ballman wrote:

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman updated this revision to Diff 405103. arphaman marked 4 inline comments as done. arphaman added a comment. Update to address review feedback, remove `appendToken` which is not needed as we're can just `setTokens` instead (it's a new macro info) CHANGES SINCE LAST ACTION https://revie

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman added a comment. Thanks, that feedback makes sense. I'll update the patch today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

aaron.ballman added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { dexonsmith wrote: > aaron.ballman wrote: > > dexonsmith wrote

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

dexonsmith added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { aaron.ballman wrote: > dexonsmith wrote: > > aaron.ballman wrote

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

aaron.ballman added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { dexonsmith wrote: > aaron.ballman wrote: > > Should we do thi

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

dexonsmith added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { aaron.ballman wrote: > Should we do this dance for 32-bit system

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

aaron.ballman added a comment. Just some minor nits from me, but generally LG. Comment at: clang/include/clang/Lex/MacroInfo.h:243 - using tokens_iterator = SmallVectorImpl::const_iterator; + using tokens_iterator = const Token *; + I think this should be a

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

egorzhdan accepted this revision. egorzhdan added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

ributzka accepted this revision. ributzka added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commi

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman created this revision. arphaman added reviewers: ravikandhadai, egorzhdan, aaron.ballman, rsmith. Herald added subscribers: ributzka, kristof.beyls, mgorny. arphaman requested review of this revision. Recently we observed high memory pressure caused by clang during some parallel builds.