[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d941d6d21e9: [clang][dataflow] Add transfer functions for constructors (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117218/new/ http

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:105 - assert(SubExpr != nullptr); +if (S->getCastKind() == CK_LValueToRValue) { auto *SubExprVal = Env.getValue(*SubExpr, SkipPast::Reference); ymandel wrote

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev updated this revision to Diff 399968. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117218/new/ https://reviews.llvm.org/D117218 Files: clang/li

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:105 - assert(SubExpr != nullptr); +if (S->getCastKind() == CK_LValueToRValue) { auto *SubExprVal = Env.getValue(*SubExpr, SkipPast::Reference

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1362 + LangStandard::lang_cxx17); +} + xazax.hun wrote: > I think this changed from 14 to 17 in the last revision. Is this intentional? Not intentional. Thanks

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev updated this revision to Diff 399714. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117218/new/ https://reviews.llvm.org/D117218 Files: clang/li

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1362 + LangStandard::lang_cxx17); +} + I think this changed from 14 to 17 in the last revision. Is this intentional? Repository: rG LLVM Github Monorepo

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev updated this revision to Diff 399707. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117218/new/ https://reviews.llvm.org/D117218 Files: clang/li

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:114 +} else if (S->getCastKind() == CK_NoOp) { + auto *SubExprLoc = Env.getStorageLocation(*SubExpr, SkipPast::None); + if (SubExprLoc ==

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:114 +} else if (S->getCastKind() == CK_NoOp) { + auto *SubExprLoc = Env.getStorageLocation(*SubEx

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis