[PATCH] D117036: [clangd] Remove --inlay-hints flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG54eb70886cda: [clangd] Remove --inlay-hints flag (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117036/new/ https://reviews.llvm.org

[PATCH] D117036: [clangd] Remove --inlay-hints flag

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, as discussed offline, i was mostly worried about the user confusion we would get when people can't turn it off with `--inlay-hints=false` but this has both made it into clangd-13 a

[PATCH] D117036: [clangd] Remove --inlay-hints flag

sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:296 RetiredFlag ClangTidyChecks("clang-tidy-checks"); +RetiredFlag InlayHints("inlay-hints"); kadircet wrote: > oops, missed this one in the previous revision. > > any r

[PATCH] D117036: [clangd] Remove --inlay-hints flag

kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:296 RetiredFlag ClangTidyChecks("clang-tidy-checks"); +RetiredFlag InlayHints("inlay-hints"); oops, missed this one in the previous revision. any reason for not directly

[PATCH] D117036: [clangd] Remove --inlay-hints flag

sammccall added a comment. In D117036#3234786 , @kadircet wrote: > nit: I'd rename the patch to `remove` rather than `retire`. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117036/new/ https://revie

[PATCH] D117036: [clangd] Remove --inlay-hints flag

sammccall updated this revision to Diff 399556. sammccall retitled this revision from "[clangd] Retire --inlay-hints flag" to "[clangd] Remove --inlay-hints flag". sammccall added a comment. rename patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org