[PATCH] D116983: Clone constructor template parameters when creating deduction guide

2022-01-12 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2174 + Args.addOuterTemplateArguments(SubstArgs); + Args.addOuterRetainedLevel(); + NamedDecl *NewParam = transformTemplateParameter(Param, Args); aeubanks wrote: > rsmith wr

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

2022-01-12 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2174 + Args.addOuterTemplateArguments(SubstArgs); + Args.addOuterRetainedLevel(); + NamedDecl *NewParam = transformTemplateParameter(Param, Args); rsmith wrote: > This oute

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

2022-01-12 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 399514. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116983/new/ https://reviews.llvm.org/D116983 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/Modules/Inputs/ctad/a.

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

2022-01-12 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. rsmith added inline comments. aeubanks published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/lib/Sema/SemaTemplate.cpp:2174 + Args.addOuterTemplateArguments(SubstArgs); +