This revision was automatically updated to reflect the committed changes.
sammccall marked 3 inline comments as done.
Closed by commit rG2b2dbe6126f8: [clangd] Selection: Prune gtest TEST()s
earlier (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D116978?vs=398876&id=
sammccall marked 3 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:306
+// If the node starts after the selection ends, it is not selected.
+// All tokens a macro location might claim are >= its expansion site.
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, this looks good.
Comment at: clang-tools-extra/clangd/Selection.cpp:306
+// If the node starts after the selection ends, it is not selected.
+// All tokens a
sammccall updated this revision to Diff 398876.
sammccall added a comment.
Rebase (offsetInSelFile)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116978/new/
https://reviews.llvm.org/D116978
Files:
clang-tools-extra/clangd/Selection.cpp
Index:
sammccall updated this revision to Diff 398757.
sammccall added a comment.
Use the other end too
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116978/new/
https://reviews.llvm.org/D116978
Files:
clang-tools-extra/clangd/Selection.cpp
Index: cl
sammccall created this revision.
sammccall added a reviewer: usaxena95.
Herald added subscribers: kadircet, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
When searching for AST nodes
