[PATCH] D116960: [ADT] Add an in-place version of toHex()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hans marked 2 inline comments as done. Closed by commit rG83797c03d2ee: [ADT] Use a lookup table in hexdigit() and call that from toHex() (authored by hans). Changed p

[PATCH] D116960: [ADT] Add an in-place version of toHex()

hans marked 2 inline comments as done. hans added a comment. In D116960#3232461 , @dexonsmith wrote: > Mostly LGTM, just a couple of comments on the drive-by changes to > `hexdigit()` (I might split that (and the new call in toHex()) into a > separate

[PATCH] D116960: [ADT] Add an in-place version of toHex()

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Mostly LGTM, just a couple of comments on the drive-by changes to `hexdigit()` (I might split that (and the new call in toHex()) into a separate commit, but if you keep them here pleas

[PATCH] D116960: [ADT] Add an in-place version of toHex()

hans updated this revision to Diff 398704. hans added a comment. (avoid toStringRef -> arrayRefFromStringRef by reshuffling the toHex overloads) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116960/new/ https://reviews.llvm.org/D116960 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/

[PATCH] D116960: [ADT] Add an in-place version of toHex()

hans updated this revision to Diff 398699. hans added a comment. Trying to upload the right diff this time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116960/new/ https://reviews.llvm.org/D116960 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/include/llvm/ADT/StringExtras.h llv

[PATCH] D116960: [ADT] Add an in-place version of toHex()

hans created this revision. hans added reviewers: thakis, arlosi, rnk. Herald added subscribers: dexonsmith, hiraditya. hans requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. and use that to simplify MD5's hex string code which was previ