[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

craig.topper added a comment. In D116935#3233751 , @fhahn wrote: > Another rebase. I am planning to land this later today, unless there are > additional concerns with respect to the fold in Clang after my latest > response. Thanks, Florian. I have no a

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

fhahn added a comment. In D116935#3232763 , @craig.topper wrote: > Do the programs in compile-time tracker make much use of bitfields? I'd expect some bitfields, but nothing excessive/pathological. > Is there any indication in rdar://7362516 what progr

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

craig.topper added a comment. In D116935#3232584 , @fhahn wrote: > Rebased and made sure comments are consistent between different folders. > > In D116935#3232227 , @craig.topper > wrote: > >> In D116935#3232203

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

craig.topper added a comment. In D116935#3232203 , @lebedev.ri wrote: > In D116935#3232126 , @craig.topper > wrote: > >> If I remember correctly, the Or and And folds for 0 and all 1s are there to >> optimize b

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

lebedev.ri added a comment. In D116935#3232126 , @craig.topper wrote: > If I remember correctly, the Or and And folds for 0 and all 1s are there to > optimize bitfield codegen for the frontend. Are we losing that optimization > if this patch goes in be

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

craig.topper added a comment. If I remember correctly, the Or and And folds for 0 and all 1s are there to optimize bitfield codegen for the frontend. Are we losing that optimization if this patch goes in before switching clang to InstSimplifyFolder? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

nikic accepted this revision. nikic added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116935/new/ https://reviews.llvm.org/D116935 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D116935: [IRBuilder] Introduce folder using inst-simplify, use for Or fold.

nikic added a comment. In D116935#3231615 , @fhahn wrote: > In D116935#3231477 , @nikic wrote: > >> Why do we need / want to use the InstSimplifyFolder in SROA? > > I don't have any strong opinions either way. The