[PATCH] D116904: Fix build failure with MSVC in C++20 mode

2022-01-13 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG971bd6f83440: Fix build failure with MSVC in C++20 mode (authored by Godin, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116904/new

[PATCH] D116904: Fix build failure with MSVC in C++20 mode

2022-01-13 Thread Evgeny Mandrikov via Phabricator via cfe-commits
Godin added a comment. Thank you for the review @sammccall ! Can someone please commit this on my behalf since I do not have commit rights? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116904/new/ https://reviews.llvm.org/D116904

[PATCH] D116904: Fix build failure with MSVC in C++20 mode

2022-01-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Much nicer :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116904/new/ https://reviews.llvm.org/D116904 ___

[PATCH] D116904: Fix build failure with MSVC in C++20 mode

2022-01-09 Thread Evgeny Mandrikov via Phabricator via cfe-commits
Godin created this revision. Godin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this patch when using CMAKE_CXX_STANDARD=20 and MSVC 19.30.30705.0 compilation fails with clang\lib\Tooling\Syntax\Tree.cpp(347): error C2666: 'cla