[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 471209. craig.topper added a comment. Add to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISCV.h llvm/docs/R

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. There were no objections on the call. Looks good to me - two minor changes before landing that would make sense: - Fraser suggested tweaking the patch description - Probably worth adding this to `do

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

asb added a comment. I've put it on the agenda for the call today so we can close this off (I figure given it's been sitting so long, waiting a few extra days to cover it in the call is no big deal). But if the data shows this overall improves things, I think it's a sensible change to make. R

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

frasercrmck added a comment. I agree with @reames, though I do think the patch description could use a rewrite. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 ___

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

reames added a comment. Just want to note that I have no strong opinion on this patch. It doesn't seem unreasonable, and I'm comfortable with this being an empirically driven decision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ ht

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper added a comment. In D116735#3857705 , @zixuan-wu wrote: > In D116735#3429850 , @craig.topper > wrote: > >> I'm seeing a regression on 401.bzip2 and possibly 471.astar. And I'm not >> seeing large im

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

zixuan-wu added a comment. In D116735#3429850 , @craig.topper wrote: > I'm seeing a regression on 401.bzip2 and possibly 471.astar. And I'm not > seeing large improvements on 471.omnetpp or 483.xalancbmk. LGTM. But do you still get regression on spec?

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 465165. craig.topper added a comment. Add requested comment to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISCV.h l

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 465162. craig.topper added a comment. Use TT.isRISCV64() in AutoUpgrade.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISC

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 465152. craig.topper marked 2 inline comments as done. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o