[PATCH] D116630: [clangd] Handle declarators more consistently in Selection.

2022-01-05 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG96f5cc1ee417: [clangd] Handle declarators more consistently in Selection. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D116630?v

[PATCH] D116630: [clangd] Handle declarators more consistently in Selection.

2022-01-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:757 if (const auto *TL = N.get()) { - // e.g. EltType Foo[OuterSize][InnerSize]; - // ~ ArrayTypeLoc

[PATCH] D116630: [clangd] Handle declarators more consistently in Selection.

2022-01-05 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks better! Comment at: clang-tools-extra/clangd/Selection.cpp:756 +claimRange( +SourceRange(FTL.getParensRange().getBegin(), FTL.getEndLoc

[PATCH] D116630: [clangd] Handle declarators more consistently in Selection.

2022-01-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Because declarators n