This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd0744585f9ea: [Clang] Initial support for linking offloading
code in tool (authored by jhuber6).
Changed prior to commit:
https://reviews.llvm.org
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, as part of the patch set, and given the runtime test for coverage.
Some nits are left for later though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://re
jhuber6 updated this revision to Diff 404598.
jhuber6 added a comment.
Maxing suggested changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116627/new/
https://reviews.llvm.org/D116627
Files:
clang/tools/clang-linker-wrapper/ClangLinkerWrappe
jhuber6 added inline comments.
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:425
+ ErrorOr NvlinkPath = sys::findProgramByName(
+ "nvlink", sys::path::parent_path(LinkerExecutable));
+ if (!NvlinkPath)
jdoerfert wrote:
> Unsure why we
jdoerfert added a comment.
Same as the other commit, where is this tested?
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:425
+ ErrorOr NvlinkPath = sys::findProgramByName(
+ "nvlink", sys::path::parent_path(LinkerExecutable));
+ if (!NvlinkPath)
---
jhuber6 updated this revision to Diff 397593.
jhuber6 added a comment.
Need to tell llc to make position independent code so we can link it properly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116627/new/
https://reviews.llvm.org/D116627
Files:
jhuber6 updated this revision to Diff 397589.
jhuber6 added a comment.
Small changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116627/new/
https://reviews.llvm.org/D116627
Files:
clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
Inde
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb.
Herald added subscribers: pengfei, tpr.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
This patch adds the initial s
