This revision was automatically updated to reflect the committed changes.
Closed by commit rGba845787b3fd: [clang][sema] Add missing diagnostic parameter
(authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116595/new/
https://review
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I think the test behavior is pretty mysterious and there's likely some other
bug happening, but this is incremental progress and definitely fixes an issue,
so LGTM!
==
tbaeder added inline comments.
Comment at: clang/test/Modules/cxx20-export-import.cpp:1-2
+
+// RUN: %clang_cc1 -std=c++20 -fmodules -fmodules-cache-path=%t
-fimplicit-module-maps -I%S/Inputs -stdlib=libc++ -verify %s
+export import dummy; // expected-error {{export declaration
tbaeder updated this revision to Diff 399925.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116595/new/
https://reviews.llvm.org/D116595
Files:
clang/lib/Sema/SemaModule.cpp
clang/test/Modules/cxx20-export-import.cpp
Index: clang/test/Modules/cxx20-export-import.cpp
===
aaron.ballman added inline comments.
Comment at: clang/test/Modules/cxx20-export-import.cpp:1-2
+
+// RUN: %clang_cc1 -std=c++20 -fmodules -fmodules-cache-path=%t
-fimplicit-module-maps -I%S/Inputs -stdlib=libc++ -verify %s
+export import dummy; // expected-error {{export declar
tbaeder created this revision.
tbaeder added a reviewer: rsmith.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The test case otherwise fails an assertion in Diagnostic::getArgKind():
clang++:
/home/tbaeder/code/llvm-project/cl
