[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8239af0eeed: [OpenMP] Add support for extracting device code in linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, as part of the patch set, and given the runtime test for coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116545/new/ https://r

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jhuber6 added a comment. In D116545#3284541 , @jdoerfert wrote: > what commit contains the tests? The previous four have clang tests, showing that we call this tool with the expected arguments. Testing the tool itself requires running it, so I was thin

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jdoerfert added a comment. what commit contains the tests? Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:435 +Arg = **NewFileOrErr; + } +} jhuber6 wrote: > jdoerfert wrote: > > Does this work with the "do not strip option"

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:258 + if (ToBeDeleted.empty()) +return None; + jdoerfert wrote: > if (!StripSections) > return None; Fixed this later, I could rebase it so it applies here i

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jdoerfert added a comment. Can we test this, or is it tested with a follow up commit at least? If so, which one (add to commit message as well, e.g., tests contained in D...). Some notes, exclusively on the unused do not strip flag. Everything else looks good reading it. Comm

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jhuber6 updated this revision to Diff 404035. jhuber6 added a comment. Changing section embedding after adding filenames previously. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116545/new/ https://reviews.llvm.org/D116545 Files: clang/tools/cl

[PATCH] D116545: [OpenMP] Add support for extracting device code in linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: guansong, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patchs add s