[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. Tests are passing again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116541/new/ https://reviews.llvm.org/D116541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. Removed the two lines in rG28c15341368b , let me know if this lets the tests pass. I'll look into getting an access somehow so I can reproduce this and figure it out. Repository: rG LLVM Github Mon

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3287379 , @thakis wrote: > Just build and run tests on any mac. This fails on 3 different macs I tried > (2x arm, 1x intel), in a bunch of different build configs. > > For the particular build I sent the output from, t

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. ps "This is inconvenient to revert since 20 patches landed" means you're landing too many patches too quickly. This landed less than 24h ago, so if it's difficult to revert, that's a bit of a problem for the project, right? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. In D116541#3287342 , @jhuber6 wrote: > In D116541#3287330 , @thakis wrote: > >> Tests have been failing on Mac for over 20 hours now. Time to revert and fix >> async? >> >>% bin/clang

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3287330 , @thakis wrote: > Tests have been failing on Mac for over 20 hours now. Time to revert and fix > async? > >% bin/clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda > -fopenmp-new-driver -no-c

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. Tests have been failing on Mac for over 20 hours now. Time to revert and fix async? % bin/clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -fopenmp-new-driver -no-canonical-prefixes -ccc-print-bindings /Users/thakis/src/llvm-project/clang/test/Driver/o

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3285927 , @thakis wrote: > Still failing: http://45.33.8.238/macm1/26873/step_7.txt It seems what's happening here is that we are building the host.bc twice, this will work fine but isn't ideal. I prevent this manuall

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3285927 , @thakis wrote: > Still failing: http://45.33.8.238/macm1/26873/step_7.txt Weird, can you show me what `-fopenmp -fopenmp-targets=nvptx64 -fopenmp-new-driver -ccc-print-bindings` looks like there? I'm not sur

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. Still failing: http://45.33.8.238/macm1/26873/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116541/new/ https://reviews.llvm.org/D116541 ___ cfe-commits mailing list cf

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added a comment. In D116541#3285455 , @thakis wrote: > Looks like this breaks tests on macOS: > http://45.33.8.238/macm1/26856/step_7.txt > > Please take a look and revert for now if it takes a while to fix (maybe just > needs an explicit triple

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/26856/step_7.txt Please take a look and revert for now if it takes a while to fix (maybe just needs an explicit triple?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9ace9e9a58: [OpenMP] Introduce new flag to change offloading driver pipeline (authored by jhuber6). Changed prior to commit: https://reviews.llv

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Driver.h:45 +class Command; +class Compilation; +class JobList; JonChesterfield wrote: > This looks like it should be a breaking change - InputInfo is no longer > forward declared. Would it be

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. This looks reasonable to me, though I'd prefer we keep the forward declare. The scalar->vector transform is mechanical and the `if (Args.hasArg(options::OPT_fopenmp_new_drive

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 updated this revision to Diff 397089. jhuber6 added a comment. Updating to only contain this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116541/new/ https://reviews.llvm.org/D116541 Files: clang/include/clang/Driver/Driver.h

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb. Herald added subscribers: ormris, dexonsmith, dang, guansong, hiraditya, yaxunl, mgorny. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan