[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed8ff29aa683: [clang-tidy] Fix false positive in modernize-pass-by-value (authored by courbet). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

courbet updated this revision to Diff 397543. courbet added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116535/new/ https://reviews.llvm.org/D116535 Files: clang-tools-extra/clang-tidy/modernize/PassByValueC

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

courbet marked 2 inline comments as done. courbet added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116535/new/ https://reviews.llvm.org/D116535 ___ cfe-commits mailing list cfe-comm

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

flx accepted this revision. flx added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp:108 +/// Returns true the given constructor is part of a lvalue/rvalue reference +/// pair, i.e. `Para

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

courbet created this revision. courbet added reviewers: alexfh, flx, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. courbet requested review of this revision. Herald added a project: clang-tools-extra. The check should not trigger on lvalue/rvalue overload pairs: struct S {