This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
aganea marked 3 inline comments as done.
Closed by commit rG5af2433e1794: [clang-cl] Support the /HOTPATCH flag
(authored by aganea).
Changed prior to commit:
https:
hans added inline comments.
Comment at: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp:13
+// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s
--check-prefix=HOTPATCH
+// ERR-HOTPATCH: error: unsupported option '/hotpatch' for target
+// HOTPATCH: S_COMPILE3 [size = [[#]
aganea marked 2 inline comments as done.
aganea added inline comments.
Comment at: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp:13
+// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s
--check-prefix=HOTPATCH
+// ERR-HOTPATCH: error: unsupported option '/hotpatch' for t
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm with comments
Comment at: clang/test/CodeGenCXX/debug-info-hotpatch-arm.cpp:13
+// RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s
--check-prefix=HOTPATCH
+// ERR-HOT
aganea added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2493
MarshallingInfoInt>;
+def fhotpatch : Flag<["-"], "fhotpatch">, Group, Flags<[CC1Option]>,
+ HelpText<"Ensure that all functions can be hotpatched at runtime">,
hans wrote:
>
aganea updated this revision to Diff 399168.
aganea marked 4 inline comments as done.
aganea edited the summary of this revision.
aganea added a comment.
Herald added a subscriber: kristof.beyls.
As suggested by @hans
Also added test coverage for ARM/ARM64.
Repository:
rG LLVM Github Monorepo
hans added a comment.
Cool!
I'd suggesting adding a note to llvm/docs/ReleaseNotes.rst at the same time :-)
Comment at: clang/include/clang/Basic/CodeGenOptions.def:142
+CODEGENOPT(HotPatch, 1, 0) ///< Supports the Microsoft /HOTPATCH flag and would
+
aganea updated this revision to Diff 397063.
aganea added a subscriber: saudi.
aganea added a comment.
Fix tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116511/new/
https://reviews.llvm.org/D116511
Files:
clang/include/clang/Basic/CodeGen
aganea created this revision.
aganea added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter.
Herald added subscribers: ormris, dexonsmith, dang, pengfei, hiraditya.
aganea requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cf
