[PATCH] D116502: [clangd] Helper for determining member insertion point.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGfe68088d44f7: [clangd] Helper for determining member insertion point. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116502: [clangd] Helper for determining member insertion point.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! In D116502#3217270 , @sammccall wrote: > In D116502#3217084 , @kadircet > wrote: > >> We

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall marked 2 inline comments as done. sammccall added a comment. In D116502#3217084 , @kadircet wrote: > We have some logic in AddUsing tweak to determine insertion point based on > AST. i think it makes sense to migrate it to these helpers too. T

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall updated this revision to Diff 397037. sammccall added a comment. Fix access protection bug, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116502/new/ https://reviews.llvm.org/D116502 Files: clang-tools-extra/clangd/CMake

[PATCH] D116502: [clangd] Helper for determining member insertion point.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/InsertionPoint.cpp:51 +} else { + assert(A.Direction == Anchor::Below); + if (LastMatched && !Matches) nit: use a switch? Comment at: clang-tools-extra/

[PATCH] D116502: [clangd] Helper for determining member insertion point.

kadircet added a comment. We have some logic in AddUsing tweak to determine insertion point based on AST. i think it makes sense to migrate it to these helpers too. There's some more logic in extract variable/function too. Extract variable seems too elaborate as it actually looks at statements,

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall updated this revision to Diff 396978. sammccall added a comment. Oops, revert wrong patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116502/new/ https://reviews.llvm.org/D116502 Files: clang-tools-extra/clangd/CMakeLists.txt clang

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall updated this revision to Diff 396977. sammccall added a comment. [clangd] Add code action to generate a constructor for a C++ class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116502/new/ https://reviews.llvm.org/D116502 Files: clan

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall updated this revision to Diff 396953. sammccall added a comment. Fix stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116502/new/ https://reviews.llvm.org/D116502 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall created this revision. sammccall added a reviewer: dgoldman. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. To be used