This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
dgoldman marked an inline comment as done.
Closed by commit rGdd72ae3dcc68: [clang][ObjC] Add fix it for missing methods
in impl (authored by dgoldman).
Repository:
dgoldman marked an inline comment as done.
dgoldman added inline comments.
Comment at: clang/lib/Sema/SemaDeclObjC.cpp:2241
+method->print(Out, Policy);
+Str.append(" {\n\n}\n\n");
+
sammccall wrote:
> sammccall wrote:
> > nit: mixing string & output stre
dgoldman updated this revision to Diff 397336.
dgoldman marked 4 inline comments as done.
dgoldman added a comment.
Fixes for review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116417/new/
https://reviews.llvm.org/D116417
Files:
clang/lib/Sema
sammccall added a comment.
Thanks, this looks good!
Comment at: clang/lib/Sema/SemaDeclObjC.cpp:2237
+// a better place to put it.
+std::string Str;
+llvm::raw_string_ostream Out(Str);
Str -> FixitStr
The comment is IMO too verbose, maybe just "//
dgoldman updated this revision to Diff 396690.
dgoldman added a comment.
Add a test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116417/new/
https://reviews.llvm.org/D116417
Files:
clang/lib/Sema/SemaDeclObjC.cpp
clang/test/FixIt/fixit-objc-m
dgoldman created this revision.
dgoldman requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We suggest inserting the method with an empty body at the end
of the implementation decl.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm
