[PATCH] D116395: [Clang] Emit warning for -x option without effects

qiucf added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Abandon this since we have rGe2a1f8ec27b88be670cd867c43588f24516d2bbf . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116395: [Clang] Emit warning for -x option without effects

awarzynski added inline comments. Comment at: clang/test/Driver/redundant-args.c:2 +// RUN: %clang -target x86_64-apple-darwin10 -Werror -x c -x c -fsyntax-only %s +// RUN: %clang -target x86_64-apple-darwin10 %s -### -x c 2>&1 | FileCheck %s + hans wrote: > Thes

[PATCH] D116395: [Clang] Emit warning for -x option without effects

hans added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2416 } + if (Inputs.size() == InputsBeforeOptX && InputTypeArg != nullptr) +Diag(diag::warn_drv_ignored_option_x) << InputTypeArg->getValue(0); Could we end up here in clang-cl mode with

[PATCH] D116395: [Clang] Emit warning for -x option without effects

qiucf added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116395/new/ https://reviews.llvm.org/D116395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D116395: [Clang] Emit warning for -x option without effects

qiucf created this revision. qiucf added reviewers: rsmith, hans, thakis, awarzynski, brad, phosek. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Things might be confusing for people not familiar with how this option works. Add thi